Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade controller-runtime #119

Closed
2 tasks
Tracked by #2
muralov opened this issue Sep 28, 2023 · 0 comments · Fixed by kyma-project/kyma#18250
Closed
2 tasks
Tracked by #2

Upgrade controller-runtime #119

muralov opened this issue Sep 28, 2023 · 0 comments · Fixed by kyma-project/kyma#18250
Assignees
@muralov

Comments

@muralov
Copy link
Contributor

muralov commented Sep 28, 2023 •
edited by grischperl
Loading

Description

The controller-runtime and client-go packages need to be upgraded so that Informers can be shut down. This upgrade introduces breaking changes and is not straight-forward.

In the future, the controller-runtime may introduce StopWatch, then we don't have to implement it ourselves here

This ticket is related to the move-code ticket.

Tasks

  • Find out which path is easier: copy code to EM and upgrade then OR upgrade in EC, copy code later

Acceptance Criteria

  • Use latest versions of controller-runtime for EC
@muralov muralov mentioned this issue Sep 28, 2023
Closed
42 tasks
@muralov muralov self-assigned this Sep 28, 2023
@muralov muralov changed the title Upgrade controller-runtime and client-go Upgrade controller-runtime Sep 28, 2023
@muralov muralov linked a pull request Sep 29, 2023 that will close this issue
Upgrade controller-runtime to 0.15.2 kyma-project/kyma#18250
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muralov muralov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade controller-runtime to 0.15.2 muralov/kyma
1 participant
@muralov