Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include consumer name as label in eventing-manager metrics #208

Closed
k15r opened this issue Nov 2, 2023 · 0 comments · Fixed by #217
Closed

include consumer name as label in eventing-manager metrics #208

k15r opened this issue Nov 2, 2023 · 0 comments · Fixed by #217

Comments

@k15r
Copy link
Contributor

k15r commented Nov 2, 2023

Descriptions

the current version of all dispatching metrics is labelled with

  • name of the subscription
  • namespace of the subscription
  • eventtype

as one subscription can cover multiple eventtypes but one nats subscription is in our implementation bound to one eventtype matching consumer stats and dispatching stats would be easier if the metrics could include the consumer id as a label.

Acceptance

  • include consumer name in the following metrics:
    • eventing_ec_nats_delivery_per_subscription_total
    • eventing_ec_nats_subscriber_dispatch_duration_seconds
@k15r k15r linked a pull request Nov 20, 2023 that will close this issue
@k15r k15r closed this as completed Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant