Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eventing Manager only uses generic labels for its runtime components #259

Closed
6 tasks done
Tracked by #258
k15r opened this issue Nov 20, 2023 · 1 comment · Fixed by #264
Closed
6 tasks done
Tracked by #258

Eventing Manager only uses generic labels for its runtime components #259

k15r opened this issue Nov 20, 2023 · 1 comment · Fixed by #264
Assignees
Milestone

Comments

@k15r
Copy link
Contributor

k15r commented Nov 20, 2023

Description

only generic labels are used on runtime components deployed by eventing manager (or lifecycle manager for eventing-manager) to relate those component to the eventing manager.

Acceptance

  • no generic labels are used on any of the eventing-manager components
  • labels can be used to distinguish clearly between components related to eventing-manager and other components
  • upgrading from previous versions of the eventing-manager works
  • labels are consistent
  • resources created by the eventing-manager are labeled with app.kubernetes.io/created-by: eventing-manager
  • labels follow standards are documented here or here

if updating selectors is not supported at the moment (eg for deployments created for the EPP) just update the labels on the deployment, and in the pod template, but leave updating the actual selector to a followup ticket

@marcobebway
Copy link
Contributor

marcobebway commented Dec 12, 2023

For the time being, we added common labels for the resources managed by the Eventing manager.
Updating the selectors will happen in a later ticket which should focus on doing the update without downtime.

@friedrichwilken friedrichwilken added this to the 1.0.2 milestone Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants