Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprovision of resources deployed by eventing-manager #34

Closed
3 tasks done
Tracked by #2
mfaizanse opened this issue Jul 31, 2023 · 1 comment · Fixed by #92
Closed
3 tasks done
Tracked by #2

Deprovision of resources deployed by eventing-manager #34

mfaizanse opened this issue Jul 31, 2023 · 1 comment · Fixed by #92
Assignees
@muralov
Labels
area/eventing Issues or PRs related to eventing

Comments

@mfaizanse
Copy link
Member

mfaizanse commented Jul 31, 2023 •
edited by muralov
Loading

Description:

Delete resources created by the eventing manager.

Note: Deletion of Eventing CR is not removing ClusterRoles and ClusterRoleBindings from the cluster, even though the owner references are set. Seems like k8s is not performing garbage collection for ClusterRoles and ClusterRoleBindings when the owner is deleted. We can specifically delete ClusterRoles and ClusterRoleBindings in our deletion logic.

Acceptance Criteria:

  • If eventing CR was deleted, all correlating resources should be deleted as well.
  • Existing subscriptions in the cluster should stop eventing from being deprovisioned.
  • A condition should give useful information to the customer for the reason a deletion is not feasible.
@mfaizanse mfaizanse mentioned this issue Jul 31, 2023
Closed
42 tasks
@mfaizanse mfaizanse changed the title Deprovision Deprovision of resources deployed by eventing-manager Jul 31, 2023
@muralov muralov added the area/eventing Issues or PRs related to eventing label Aug 18, 2023
@muralov muralov self-assigned this Sep 13, 2023
@muralov
Copy link
Contributor

muralov commented Sep 13, 2023

K8s garbage collector doesn't delete cluster-scoped resources owned by namespace-scoped ones. Here the doc

@muralov muralov linked a pull request Sep 15, 2023 that will close this issue
Delete Cluster Scoped Resources #92
Merged
@muralov muralov closed this as completed Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muralov muralov

Labels
area/eventing Issues or PRs related to eventing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Delete Cluster Scoped Resources muralov/eventing-manager
2 participants
@mfaizanse @muralov