Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React to NATS+EventMesh backend config modifications on Eventing CR #45

Closed
8 tasks done
Tracked by #2
mfaizanse opened this issue Aug 9, 2023 · 1 comment · Fixed by #87 or #123
Closed
8 tasks done
Tracked by #2

React to NATS+EventMesh backend config modifications on Eventing CR #45

mfaizanse opened this issue Aug 9, 2023 · 1 comment · Fixed by #87 or #123
Assignees
Labels
area/eventing Issues or PRs related to eventing

Comments

@mfaizanse
Copy link
Member

mfaizanse commented Aug 9, 2023

Currently, when an Eventing CR spec is created then the NATS/EventMesh subscription-manager object is initialised and started with the configurations from the CR. But if someone later changes the configs in the CR then it will not update it in the subscription-manager object.

Tasks:

  • Identify if CR spec changed or not.
    • Keep an in-memory hash to identify if spec has changed. The hash should only be based on NATS/EventMesh relevant fields in the spec e.g. backend, logging etc.
    • If the spec changed then change the eventing CR status to Processing.
  • If changed restart/re-init the NATS/EventMesh subscription-manager object with the new configs.
    • Do not do cleanup when stopping the NATS/EventMesh subscription-manager.
  • If changing some config for NATS/EventMesh causes the subscription manager to start (because on backend we cannot change that config), then discuss with team that should we make that field immutable?

Acceptance Criteria:

  • Changing the Spec should update the relevant NATS/EventMesh eventing infra.
  • Do the implementation in separate PRs for NATS and EventMesh.
@mfaizanse mfaizanse mentioned this issue Aug 9, 2023
42 tasks
@muralov muralov added the area/eventing Issues or PRs related to eventing label Aug 18, 2023
@mfaizanse mfaizanse changed the title React to NATS backend config modifications on Eventing CR React to NATS+EventMesh backend config modifications on Eventing CR Aug 25, 2023
@grischperl grischperl self-assigned this Sep 5, 2023
@grischperl grischperl linked a pull request Sep 12, 2023 that will close this issue
@grischperl grischperl linked a pull request Sep 28, 2023 that will close this issue
@grischperl
Copy link
Contributor

Open, until EventMesh PR is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/eventing Issues or PRs related to eventing
Projects
None yet
3 participants