Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix defaulting rules to set defaults depending on NATS or EventMesh backend #80

Closed
3 tasks
Tracked by #231
grischperl opened this issue Sep 6, 2023 · 5 comments
Closed
3 tasks
Tracked by #231
Labels
area/eventing Issues or PRs related to eventing

Comments

@grischperl
Copy link
Collaborator

grischperl commented Sep 6, 2023

Questions:

  • Is it possible to do it using the defaulting rules?

Description

  • NATS Backend is set as the default
  • NATS related backend config values are also defined via defaulting rules (NATSStreamStorageType, etc)
  • If the backend is switched to EventMesh, the NATS backend config details remain in the CR and are always recreated upon deletion
  • => Defaulting rules for the backend config values need to be different depending on the backend

Acceptance Criteria

  • When NATS Backend is set, only NATS related backend config details are automatically set as default
  • When EventMesh Backend is set, only EventMesh related backend config details are automatically set as default
  • Backend config details not relevant to the active backend can be removed without their recreation
@grischperl grischperl mentioned this issue Sep 6, 2023
42 tasks
@mfaizanse mfaizanse added the area/eventing Issues or PRs related to eventing label Sep 8, 2023
@kyma-bot
Copy link

kyma-bot commented Nov 7, 2023

This issue or PR has been automatically marked as stale due to the lack of recent activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Close this issue or PR with /close

If you think that I work incorrectly, kindly raise an issue with the problem.

/lifecycle stale

@kyma-bot kyma-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 7, 2023
@k15r k15r mentioned this issue Nov 9, 2023
24 tasks
@kyma-bot
Copy link

This issue or PR has been automatically closed due to the lack of activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle stale

If you think that I work incorrectly, kindly raise an issue with the problem.

/close

@kyma-bot
Copy link

@kyma-bot: Closing this issue.

In response to this:

This issue or PR has been automatically closed due to the lack of activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle stale

If you think that I work incorrectly, kindly raise an issue with the problem.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@grischperl
Copy link
Collaborator Author

This issue can be closed as there is no longer a default backend #274

@grischperl
Copy link
Collaborator Author

/remove-lifecycle stale

@kyma-bot kyma-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/eventing Issues or PRs related to eventing
Projects
None yet
Development

No branches or pull requests

3 participants