Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed webhooks and renamed service-account #108

Merged
merged 1 commit into from
Sep 27, 2023
+25 −24
Merged

Fixed webhooks and renamed service-account #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion config/manager/manager.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ spec:
metadata:
annotations:
kubectl.kubernetes.io/default-container: manager
traffic.sidecar.istio.io/excludeInboundPorts: "9443"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the actual fix for webhooks!

labels:
control-plane: eventing-manager
app.kubernetes.io/name: eventing-manager
Expand Down Expand Up @@ -169,7 +170,7 @@ spec:
- mountPath: /tmp/k8s-webhook-server/serving-certs
name: cert
readOnly: true
serviceAccountName: eventing-controller-manager
serviceAccountName: eventing-manager
terminationGracePeriodSeconds: 10
volumes:
- name: cert
Expand Down
2 changes: 1 addition & 1 deletion config/rbac/auth_proxy_role_binding.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@ roleRef:
name: eventing-proxy
subjects:
- kind: ServiceAccount
name: eventing-controller-manager
name: eventing-manager
namespace: system
8 changes: 4 additions & 4 deletions config/rbac/auth_proxy_service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@ apiVersion: v1
kind: Service
metadata:
labels:
control-plane: controller-manager
control-plane: manager
app.kubernetes.io/name: service
app.kubernetes.io/instance: eventing-controller-manager-metrics
app.kubernetes.io/instance: eventing-manager-metrics
app.kubernetes.io/component: kube-rbac-proxy
app.kubernetes.io/created-by: eventing-manager
app.kubernetes.io/part-of: eventing-manager
app.kubernetes.io/managed-by: kustomize
name: eventing-controller-manager-metrics
name: eventing-manager-metrics
namespace: system
spec:
ports:
Expand All @@ -18,4 +18,4 @@ spec:
protocol: TCP
targetPort: https
selector:
control-plane: controller-manager
control-plane: manager
2 changes: 1 addition & 1 deletion config/rbac/leader_election_role_binding.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@ roleRef:
name: eventing-leader-election
subjects:
- kind: ServiceAccount
name: eventing-controller-manager
name: eventing-manager
namespace: system
2 changes: 1 addition & 1 deletion config/rbac/role_binding.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@ roleRef:
name: eventing-manager
subjects:
- kind: ServiceAccount
name: eventing-controller-manager
name: eventing-manager
namespace: system
6 changes: 3 additions & 3 deletions config/rbac/service_account.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@ apiVersion: v1
kind: ServiceAccount
metadata:
labels:
app.kubernetes.io/name: serviceaccount
app.kubernetes.io/instance: controller-manager-sa
app.kubernetes.io/name: eventing-manager
app.kubernetes.io/instance: manager-sa
app.kubernetes.io/component: rbac
app.kubernetes.io/created-by: eventing-manager
app.kubernetes.io/part-of: eventing-manager
app.kubernetes.io/managed-by: kustomize
name: eventing-controller-manager
name: eventing-manager
namespace: system
2 changes: 1 addition & 1 deletion config/webhook/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ kind: Kustomization
images:
- name: api-gateway
newName: europe-docker.pkg.dev/kyma-project/prod/eventing-webhook-certificates
newTag: v20230808-29d8ce01
newTag: 1.7.0
24 changes: 12 additions & 12 deletions config/webhook/webhook_configs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ metadata:
app.kubernetes.io/part-of: eventing-manager
webhooks:
- admissionReviewVersions:
- v1beta1
- v1
clientConfig:
service:
name: eventing-manager-webhook-service
Expand All @@ -20,14 +20,14 @@ webhooks:
name: msubscription.kb.io
rules:
- apiGroups:
- eventing.kyma-project.io
- eventing.kyma-project.io
apiVersions:
- v1alpha2
- v1alpha2
operations:
- CREATE
- UPDATE
- CREATE
- UPDATE
resources:
- subscriptions
- subscriptions
sideEffects: None
---
apiVersion: admissionregistration.k8s.io/v1
Expand All @@ -42,7 +42,7 @@ metadata:
app.kubernetes.io/part-of: eventing-manager
webhooks:
- admissionReviewVersions:
- v1beta1
- v1
clientConfig:
service:
name: eventing-manager-webhook-service
Expand All @@ -52,12 +52,12 @@ webhooks:
name: vsubscription.kb.io
rules:
- apiGroups:
- eventing.kyma-project.io
- eventing.kyma-project.io
apiVersions:
- v1alpha2
- v1alpha2
operations:
- CREATE
- UPDATE
- CREATE
- UPDATE
resources:
- subscriptions
- subscriptions
sideEffects: None