Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E Tests Sink #88

Merged
merged 7 commits into from
Sep 12, 2023
Merged

E2E Tests Sink #88

merged 7 commits into from
Sep 12, 2023

Conversation

muralov
Copy link
Contributor

@muralov muralov commented Sep 8, 2023 •
edited
Loading

Implement a sink for E2E tests that receive and store events for later check

  • Write the logic
  • Create Github Action for this

#77

@muralov muralov requested a review from a team as a code owner September 8, 2023 17:25
@muralov muralov requested a review from marcobebway September 8, 2023 17:25
@kyma-bot kyma-bot added area/ci Issues or PRs related to CI related topics size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 8, 2023
@muralov muralov force-pushed the e2e-sink branch 4 times, most recently from 2360955 to 2522b5a Compare September 11, 2023 12:37
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 11, 2023
@muralov muralov changed the title E2e sink E2E Tests Sink Sep 12, 2023
@mfaizanse mfaizanse requested review from mfaizanse and removed request for marcobebway September 12, 2023 08:34
@muralov
Implement Send And Get Event APIs
fcf862c
@muralov
Create GH action and Dockerfile
8e4d8de 
* Create GH action workflow
* Improve API Name and Makefile
* Don't trigger Lint and Validation for E2E Test Sink change
* Create dockerfile
* Create makefile file
* delete vs code files
@muralov
Make Webserver Port configurable
3170f1c
@muralov
Disable PR Image Upload
456bc5b
@muralov
Add paths to ignore for linting and validation
a9db829
mfaizanse
mfaizanse reviewed Sep 12, 2023
View reviewed changes
e2e/sink/Dockerfile Outdated Show resolved Hide resolved
mfaizanse
mfaizanse reviewed Sep 12, 2023
View reviewed changes
e2e/sink/cmd/main.go Outdated Show resolved Hide resolved
@muralov
Change for Review Comments
f57472d 
* Delete path ignore from lint and validation
* Clean-up Makefile
* Move sink to hack/e2e
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 12, 2023
@muralov muralov force-pushed the e2e-sink branch 4 times, most recently from b5eea5c to f57472d Compare September 12, 2023 12:36
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 12, 2023
@kyma-bot kyma-bot merged commit 5faa6ba into kyma-project:main Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfaizanse mfaizanse mfaizanse approved these changes

Assignees

@mfaizanse mfaizanse

Labels
area/ci Issues or PRs related to CI related topics lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muralov @mfaizanse @kyma-bot