Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base readiness of EPP on availability of its NATS-connection #46

Closed
4 tasks done
friedrichwilken opened this issue Oct 17, 2023 · 0 comments · Fixed by #49
Closed
4 tasks done

Base readiness of EPP on availability of its NATS-connection #46

friedrichwilken opened this issue Oct 17, 2023 · 0 comments · Fixed by #49
Assignees
Labels
area/eventing Issues or PRs related to eventing

Comments

@friedrichwilken
Copy link
Contributor

friedrichwilken commented Oct 17, 2023

Description

EPP should not report itself as ready when it is not able to send events to NATS. In an upgrade situation this should prevent a short downtime when the EPP currently reports as ready, but rejects events as it is not connected to NATS yet.

In this issue we decoupled epp readiness from nats-connection availablility. kyma-project/kyma#18298

this is a temporary fix. as soon as eventing manager was release, let's revert this.

During upgrade testing we noticed a short period

Acceptance

  • run load test to verify that during an upgrade no events are rejected by a non ready EPP
    -> this change did not fix, that no events are rejected. This is to be solved in EPP Image Update leads to NACKS #52
  • Documentation is updated (on-call manual): documentation/#463
  • SRE is notified about the change

Hint

@friedrichwilken friedrichwilken added the area/eventing Issues or PRs related to eventing label Oct 17, 2023
@k15r k15r changed the title revert decoupling epp-readiness from nats connection availability. Base readiness of EPP on availability of its NATS-connection Dec 22, 2023
@k15r k15r transferred this issue from kyma-project/kyma Jan 10, 2024
@grischperl grischperl assigned grischperl and unassigned the1bit Jan 11, 2024
@grischperl grischperl reopened this Jan 16, 2024
@friedrichwilken friedrichwilken removed their assignment Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/eventing Issues or PRs related to eventing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants