Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add case to handle no previous release tag in create changelog #39

Closed
wants to merge 1 commit into from
Closed

Add case to handle no previous release tag in create changelog #39

wants to merge 1 commit into from

Conversation

grischperl
Copy link
Contributor

@grischperl grischperl commented Jan 8, 2024 •
edited
Loading

Description

The changelog is created using a previous release tag as reference point. In case no tag exists, the script failed.

Changes proposed in this pull request:

  • Script uses hard coded sha to use as reference point in case no previous release tag exists to create the changelog
  • Add comments from NM repo to the script for explanation of the steps

Related issue(s)

@grischperl grischperl requested review from the1bit and a team as code owners January 8, 2024 09:03
@grischperl grischperl requested a review from muralov January 8, 2024 09:03
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 8, 2024
@grischperl
Copy link
Contributor Author

Closed, as problem was handled by adding a tag 0.0

@grischperl grischperl closed this Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the1bit the1bit Awaiting requested review from the1bit

@muralov muralov Awaiting requested review from muralov muralov is a code owner automatically assigned from kyma-project/eventing

Assignees
No one assigned
Labels
cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grischperl @kyma-bot