Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the configuration of seeds within the same region as the shoot [KIM/feature] #241

Open
4 of 5 tasks
Tracked by #112
tobiscr opened this issue May 29, 2024 · 3 comments
Open
4 of 5 tasks
Tracked by #112
Labels
area/control-plane Related to all activities around Kyma Control Plane kind/feature Categorizes issue or PR as related to a new feature.

Comments

@tobiscr
Copy link
Contributor

tobiscr commented May 29, 2024

Description

As part of EPIC kyma-project/kyma#18182, we are going to offer customers the option request a shoot and seed in the same region.

This requires a modification of KIM to be able to

  • Receive the information that seed and shoot should be in the same region (will be an additional boolean flag in RuntimeCR)
  • Set the proper fields in the Shoot-spec for Gardener (label-selectors for seeds)

AC:

Reasons

Enforce seed and shoot in same region to improve latency and address security related concerns.

Attachments

Relates to
kyma-project/kyma#18182

@tobiscr tobiscr added kind/feature Categorizes issue or PR as related to a new feature. area/control-plane Related to all activities around Kyma Control Plane labels May 29, 2024
@tobiscr tobiscr changed the title Support the configuration of seeds within the same region as the shoot [KIM/feature] Support the configuration of seeds within the same region as the shoot Jun 26, 2024
@tobiscr tobiscr changed the title [KIM/feature] Support the configuration of seeds within the same region as the shoot Support the configuration of seeds within the same region as the shoot [KIM/feature] Jun 26, 2024
@tobiscr
Copy link
Contributor Author

tobiscr commented Jul 25, 2024

See https://github.com/gardener/gardener/blob/v1.84.1/example/90-shoot.yaml#L365-L368 for the Shoot-spec related section that needs to be touched

@tobiscr
Copy link
Contributor Author

tobiscr commented Nov 25, 2024

PR on Gardener Side is open: it changes the determineSeed function to public. This allows us to reuse Gardener's determination logic for Seeds within KIM:

gardener/gardener#10917

@tobiscr
Copy link
Contributor Author

tobiscr commented Dec 5, 2024

Opened another PR for Gardener with an proposal to add an unique suffix to each error message replied by Gardener's reconciler: gardener/gardener#10983

This would help to reliably map error messages to Gardener reconciler problems (e.g. no seed in region found etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane Related to all activities around Kyma Control Plane kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants