Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenIDConnect CR are created without proper verification if operation succeeded #410

Closed
Disper opened this issue Oct 7, 2024 · 1 comment
Labels
area/control-plane Related to all activities around Kyma Control Plane kind/feature Categorizes issue or PR as related to a new feature.

Comments

@Disper
Copy link
Member

Disper commented Oct 7, 2024

Description

OpenIDConnect CRs responsible for OIDC configuration are created using Fire&Forget approach. We're not checking the shoot cluster if they were indeed created and healthy. We should verify if those resources are indeed created as expected.

Reasons

Invalid creation of OpenIDConnect CRs might lead to issues with customer's OIDC configuration.

Attachments
#381

@Disper Disper added kind/feature Categorizes issue or PR as related to a new feature. area/control-plane Related to all activities around Kyma Control Plane labels Oct 7, 2024
@tobiscr
Copy link
Contributor

tobiscr commented Nov 21, 2024

Review happened, errors are checked and FAILED state will be set if an error happens. Closing issue as obsolete.

@tobiscr tobiscr closed this as completed Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane Related to all activities around Kyma Control Plane kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants