Metrics use shootName (#1565)

metrics dimension name changed
kyma-project · Dec 11, 2024 · 148d69a · 148d69a
1 parent 0e9e359
commit 148d69a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/internal/btpmanager/credentials/manager.go b/internal/btpmanager/credentials/manager.go
@@ -150,11 +150,11 @@ func (s *Manager) ReconcileAll(jobReconciliationDelay time.Duration, metrics *Me
 func (s *Manager) updateMetrics(metrics *Metrics, instance internal.Instance, runtimeSkipped bool) {
 	if metrics != nil {
 		if runtimeSkipped {
-			metrics.skippedSecrets.With(prometheus.Labels{"runtime": instance.RuntimeID, "state": "skipped"}).Set(float64(1))
-			metrics.skippedSecrets.With(prometheus.Labels{"runtime": instance.RuntimeID, "state": "reconciled"}).Set(float64(0))
+			metrics.skippedSecrets.With(prometheus.Labels{"shoot": instance.InstanceDetails.ShootName, "state": "skipped"}).Set(float64(1))
+			metrics.skippedSecrets.With(prometheus.Labels{"shoot": instance.InstanceDetails.ShootName, "state": "reconciled"}).Set(float64(0))
 		} else {
-			metrics.skippedSecrets.With(prometheus.Labels{"runtime": instance.RuntimeID, "state": "reconciled"}).Set(float64(1))
-			metrics.skippedSecrets.With(prometheus.Labels{"runtime": instance.RuntimeID, "state": "skipped"}).Set(float64(0))
+			metrics.skippedSecrets.With(prometheus.Labels{"shoot": instance.InstanceDetails.ShootName, "state": "reconciled"}).Set(float64(1))
+			metrics.skippedSecrets.With(prometheus.Labels{"shoot": instance.InstanceDetails.ShootName, "state": "skipped"}).Set(float64(0))
 		}
 	}
 }

diff --git a/internal/btpmanager/credentials/metrics.go b/internal/btpmanager/credentials/metrics.go
@@ -12,7 +12,7 @@ func NewMetrics(reg prometheus.Registerer, namespace string) *Metrics {
 			Namespace: namespace,
 			Name:      "reconciled_secrets",
 			Help:      "Reconciled secrets.",
-		}, []string{"runtime", "state"}),
+		}, []string{"shoot", "state"}),
 	}
 	reg.MustRegister(m.skippedSecrets)
 	return m