Validate unique modules in kyma spec (#611)

* Validate for duplicate modules in SKR kyma

* remove webhook duplicate test

api/v1beta2/kyma_types.go

@@ -46,6 +46,8 @@ type KymaSpec struct {
 	Channel string `json:"channel"`
 
 	// Modules specifies the list of modules to be installed
+	// +listType=map
+	// +listMapKey=name
 	Modules []Module `json:"modules,omitempty"`
 }
 

api/v1beta2/webhook_kyma_crd_validation_test.go

@@ -1,38 +1,13 @@
 package v1beta2_test
 
 import (
-	"errors"
-
 	"github.com/kyma-project/lifecycle-manager/api/v1beta2"
 	"github.com/kyma-project/lifecycle-manager/pkg/testutils"
 	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
-	k8serrors "k8s.io/apimachinery/pkg/api/errors"
 )
 
 var _ = Describe("Webhook Validation Kyma Create", Ordered, func() {
-	It("should not create kyma contains duplicate module", func() {
-		kyma := testutils.NewTestKyma("test-kyma")
-		for _, module := range []string{"module1", "module1"} {
-			kyma.Spec.Modules = append(
-				kyma.Spec.Modules, v1beta2.Module{
-					ControllerName: "manifest",
-					Name:           module,
-					Channel:        v1beta2.DefaultChannel,
-				})
-		}
-		err := k8sClient.Create(webhookServerContext, kyma)
-
-		Expect(err).To(HaveOccurred())
-		var statusErr *k8serrors.StatusError
-		isStatusErr := errors.As(err, &statusErr)
-		Expect(isStatusErr).To(BeTrue())
-		Expect(statusErr.ErrStatus.Status).To(Equal("Failure"))
-		Expect(string(statusErr.ErrStatus.Reason)).To(Equal("Invalid"))
-		Expect(statusErr.ErrStatus.Message).
-			To(ContainSubstring(v1beta2.ErrDuplicateModule.Error()))
-	})
-
 	It("should create kyma without duplicate module", func() {
 		kyma := testutils.NewTestKyma("test-kyma")
 		for _, module := range []string{"module1", "module2"} {

config/crd/bases/operator.kyma-project.io_kymas.yaml

@@ -506,6 +506,9 @@ spec:
                   - name
                   type: object
                 type: array
+                x-kubernetes-list-map-keys:
+                - name
+                x-kubernetes-list-type: map
             required:
             - channel
             type: object