Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ModuleCatalog] Deprecate .spec.channel in ModuleTemplate #1839

Closed
4 tasks done
Tracked by #776
c-pius opened this issue Sep 6, 2024 · 1 comment · Fixed by #1932
Closed
4 tasks done
Tracked by #776

[ModuleCatalog] Deprecate .spec.channel in ModuleTemplate #1839

c-pius opened this issue Sep 6, 2024 · 1 comment · Fixed by #1932
Assignees
Labels
API Denotes that an issue is tied to the potential change of the API kind/feature Categorizes issue or PR as related to a new feature.

Comments

@c-pius
Copy link
Contributor

c-pius commented Sep 6, 2024

Description

In #1681 it has been decided that ModuleTemplates are tied to versions and not to channels. In #1591 we already made .spec.channel optional. We can also mark this attribute as deprecated and remove it in the future.

Reasons

Clean API from unused fields.

Acceptance Criteria

Feature Testing

No response

Testing approach

No response

Attachments

No response

@c-pius c-pius added kind/feature Categorizes issue or PR as related to a new feature. API Denotes that an issue is tied to the potential change of the API labels Sep 6, 2024
@c-pius
Copy link
Contributor Author

c-pius commented Oct 1, 2024

Proposal to be discussed: once deprecated, we can already update modulectl to issue an error when trying to provide a channel.

@LeelaChacha LeelaChacha self-assigned this Oct 6, 2024
@LeelaChacha LeelaChacha removed their assignment Oct 6, 2024
LeelaChacha added a commit to LeelaChacha/kyma-lifecycle-manager that referenced this issue Oct 6, 2024
@jeremyharisch jeremyharisch self-assigned this Oct 7, 2024
jeremyharisch added a commit to LeelaChacha/kyma-lifecycle-manager that referenced this issue Oct 9, 2024
jeremyharisch added a commit to LeelaChacha/kyma-lifecycle-manager that referenced this issue Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Denotes that an issue is tied to the potential change of the API kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants