Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check how we can make it clearer that we replace watcher image tag from config with kustomization #1951

Open
1 task
c-pius opened this issue Oct 10, 2024 · 0 comments

Comments

@c-pius
Copy link
Contributor

c-pius commented Oct 10, 2024

Description

Follow-up from https://github.com/kyma-project/lifecycle-manager/pull/1929/files#r1787653199

It may be unclear that we always overwrite the image set in skr-webhook/resources.yaml with a kustomization value from config/watcher/kustomization.yaml. We should try to make this explicit by either

  • removing the iamge field entirely from skr-webhook/resources.yaml (if possible)
  • adding a comment that it will be overwritten from X
  • setting it to a dummy value so that it is clear that we will overwrite it and it doesn't have meaning

Reason

More explicit. We may try to change the value here and are then surprised why the change doesn't take effect

AC

  • image that is used for skr-webhook is explicitly known.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant