Cleanup unused configuration fields

kyma-project · Apr 29, 2024 · 08ccde2 · 08ccde2
1 parent c98bb8e
commit 08ccde2
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 24 deletions.
diff --git a/components/operator/internal/state/controller_configuration.go b/components/operator/internal/state/controller_configuration.go
@@ -25,7 +25,6 @@ func sFnControllerConfiguration(ctx context.Context, r *reconciler, s *systemSta
 	}
 
 	configureControllerConfigurationFlags(s)
-	warnAboutDeadFields(s)
 
 	s.setState(v1alpha1.StateProcessing)
 	s.instance.UpdateConditionTrue(
@@ -37,15 +36,6 @@ func sFnControllerConfiguration(ctx context.Context, r *reconciler, s *systemSta
 	return nextState(sFnApplyResources)
 }
 
-func warnAboutDeadFields(s *systemState) {
-	if s.instance.Spec.FunctionTimeoutSec != "" {
-		s.warningBuilder.With(functionTimeoutDepreciationMessage)
-	}
-	if s.instance.Spec.FunctionRequestBodyLimitMb != "" {
-		s.warningBuilder.With(functionRequestBodyLimitDepreciationMessage)
-	}
-}
-
 func updateControllerConfigurationStatus(ctx context.Context, r *reconciler, instance *v1alpha1.Serverless) error {
 	nodesLen, err := getNodesLen(ctx, r.client)
 	if err != nil {

diff --git a/components/operator/internal/state/controller_configuration_test.go b/components/operator/internal/state/controller_configuration_test.go
@@ -232,20 +232,6 @@ func Test_sFnControllerConfiguration(t *testing.T) {
 			configurationReadyMsg)
 		require.Equal(t, v1alpha1.StateProcessing, s.instance.Status.State)
 	})
-
-	t.Run("enable dead fields", func(t *testing.T) {
-		s := &systemState{
-			warningBuilder: warning.NewBuilder(),
-			instance: v1alpha1.Serverless{
-				Spec: v1alpha1.ServerlessSpec{
-					FunctionRequestBodyLimitMb:       requestBodyLimitMbTest,
-					FunctionTimeoutSec:               timeoutSecTest,
-				},
-			},
-		}
-		warnAboutDeadFields(s)
-		require.Equal(t, fmt.Sprintf("Warning: %s; %s", functionTimeoutDepreciationMessage, functionRequestBodyLimitDepreciationMessage), s.warningBuilder.Build())
-	})
 }