Merge pull request #170 from pPrecel/remove-type-check

Remove checking external registry secret type
kyma-project · Jul 25, 2023 · 8255b54 · 8255b54
2 parents 4122afa + 92984be
commit 8255b54
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 11 deletions.
diff --git a/internal/registry/secret.go b/internal/registry/secret.go
@@ -2,6 +2,7 @@ package registry
 
 import (
 	"context"
+
 	corev1 "k8s.io/api/core/v1"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 )
@@ -25,9 +26,6 @@ func GetServerlessExternalRegistrySecret(ctx context.Context, c client.Client, n
 		return nil, client.IgnoreNotFound(err)
 	}
 
-	if secret.Type != corev1.SecretTypeDockerConfigJson {
-		return nil, nil
-	}
 	if val, ok := secret.GetLabels()[ServerlessExternalRegistryLabelRemoteRegistryKey]; !ok || val != ServerlessExternalRegistryLabelRemoteRegistryVal {
 		return nil, nil
 	}

diff --git a/internal/registry/secret_test.go b/internal/registry/secret_test.go
@@ -52,14 +52,6 @@ func Test_GetExternalRegistrySecret(t *testing.T) {
 				return secret
 			}(),
 		},
-		{
-			name: "bad type",
-			secretInEnvironment: func() *corev1.Secret {
-				secret := testRegistryFilledSecret.DeepCopy()
-				secret.Type = corev1.SecretTypeBasicAuth
-				return secret
-			}(),
-		},
 		{
 			name: "without label remote-registry",
 			secretInEnvironment: func() *corev1.Secret {