Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Małgorzata Świeca <[email protected]>
  • Loading branch information
kwiatekus and mmitoraj authored Jul 5, 2024
1 parent 9682a89 commit e9bf883
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions .github/ISSUE_TEMPLATE/feature-request.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,9 @@ Acceptance criteria might include:
- Setting a performance benchmarks.
- Compatibility requirements.
Example:
- Users should be able to configure a numeric setting via Custom Resource.
- Users should be able to configure a numeric setting via a custom resource.
- The new setting must be validated before its applied.
- The new setting, when applied, is visible in the status of Custom Resource.
- The new setting, when applied, is visible in the custom resource status.
-->
- [ ] expected behaviors, outcomes ... ?
- [ ] ... new docs / update docs ... ?
Expand All @@ -58,7 +58,7 @@ Include details on:
- target environment type: k3d, gardener, managed kyma runtime
-->
- automated unit test for the new logic
- automated integration test (new test suite? extending existing test?)
- automated integration test (a new test suite? or extending an existing test?)
- automated/manual test on SKR ?

**Attachments**
Expand All @@ -69,6 +69,6 @@ Include details on:

<!-- Include links or references to:
- Bugs that this feature might address.
- Other github issues that are dependent on or related to this one.
- Other GitHub issues that are dependent on or related to this one.
- Relevant discussions, decisions or threads.
-->

0 comments on commit e9bf883

Please sign in to comment.