From e9bf8837cf83d8c296f7e2d6f7deba31d5cf946b Mon Sep 17 00:00:00 2001 From: Krzysztof Kwiatosz Date: Fri, 5 Jul 2024 13:29:11 +0200 Subject: [PATCH] Apply suggestions from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Małgorzata Świeca --- .github/ISSUE_TEMPLATE/feature-request.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/feature-request.md b/.github/ISSUE_TEMPLATE/feature-request.md index 35ff1cf47..7e57df3cf 100644 --- a/.github/ISSUE_TEMPLATE/feature-request.md +++ b/.github/ISSUE_TEMPLATE/feature-request.md @@ -41,9 +41,9 @@ Acceptance criteria might include: - Setting a performance benchmarks. - Compatibility requirements. Example: -- Users should be able to configure a numeric setting via Custom Resource. +- Users should be able to configure a numeric setting via a custom resource. - The new setting must be validated before its applied. -- The new setting, when applied, is visible in the status of Custom Resource. +- The new setting, when applied, is visible in the custom resource status. --> - [ ] expected behaviors, outcomes ... ? - [ ] ... new docs / update docs ... ? @@ -58,7 +58,7 @@ Include details on: - target environment type: k3d, gardener, managed kyma runtime --> - automated unit test for the new logic - - automated integration test (new test suite? extending existing test?) + - automated integration test (a new test suite? or extending an existing test?) - automated/manual test on SKR ? **Attachments** @@ -69,6 +69,6 @@ Include details on: \ No newline at end of file