Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds cp2k script #38

Merged
merged 30 commits into from
Mar 5, 2024
Merged

Adds cp2k script #38

merged 30 commits into from
Mar 5, 2024

Conversation

bananenpampe
Copy link
Collaborator

Together with @PicoCentauri we would like to add an example for batched CP2K calculations from a list of ase.Atoms.
The example automatically installs cp2k and runs a testcalculation on a small frame.

@bananenpampe bananenpampe requested a review from DavideTisi March 1, 2024 11:00
Copy link

github-actions bot commented Mar 1, 2024

Here is the build version of the cookbook in this pull request: documentation.zip, you can view it locally by unzipping documentation.zip and open the index.html with your favorite browser.

@bananenpampe
Copy link
Collaborator Author

This does not work because no CP2K actually gets installed throught the conda install.
Maybe this is due to the virtual instances github action uses? - can it be changed to another instance type?

@PicoCentauri PicoCentauri force-pushed the adds_cp2k_script branch 2 times, most recently from d1262d7 to 76588e9 Compare March 5, 2024 11:10
@PicoCentauri PicoCentauri force-pushed the adds_cp2k_script branch 6 times, most recently from 0b3d0cd to 15ab8c4 Compare March 5, 2024 12:37
Copy link
Collaborator

@DavideTisi DavideTisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems very good only few typos

examples/cp2k_run_batch/setup_reftraj.py Outdated Show resolved Hide resolved
examples/cp2k_run_batch/setup_reftraj.py Outdated Show resolved Hide resolved
examples/cp2k_run_batch/setup_reftraj.py Outdated Show resolved Hide resolved
# Perform calculations using ASE calculator
# =========================================
# Above we performed the calculations using an external bash script. ASE also provides a
# calculator class that we can use the perform the caclulations with pur input file
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pur?? what you mean?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

our xD

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍😂

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐈‍⬛

Copy link
Collaborator

@DavideTisi DavideTisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i found two more typos but everything is fine

examples/cp2k_run_batch/setup_reftraj.py Outdated Show resolved Hide resolved
examples/cp2k_run_batch/setup_reftraj.py Outdated Show resolved Hide resolved
@DavideTisi DavideTisi merged commit 54ed883 into main Mar 5, 2024
2 checks passed
@DavideTisi DavideTisi deleted the adds_cp2k_script branch March 5, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants