Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Feature Selection #47

Merged
merged 13 commits into from
Mar 27, 2024
Merged

Improve Feature Selection #47

merged 13 commits into from
Mar 27, 2024

Conversation

HannaTuerk
Copy link
Contributor

Hello,
I updated the sample selection example to use equisolve (before we used skmatter). I also kept an example for feature selection directly with skmatter at the bottom.

@Luthaf Luthaf changed the title Selection Improve Feature Selection Mar 26, 2024
@HannaTuerk HannaTuerk requested a review from DavideTisi March 27, 2024 09:56
Copy link
Collaborator

@DavideTisi DavideTisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it is fine, I had to build it on my laptop. it cannot build the cp2k example but the sample selection seems ok

@HannaTuerk HannaTuerk merged commit a03b26a into main Mar 27, 2024
7 checks passed
@HannaTuerk HannaTuerk deleted the selection branch March 27, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants