Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open links by default for issues and mr #3

Open
licaon-kter opened this issue Oct 2, 2024 · 6 comments
Open

Open links by default for issues and mr #3

licaon-kter opened this issue Oct 2, 2024 · 6 comments

Comments

@licaon-kter
Copy link

licaon-kter commented Oct 2, 2024

...so Labnex will open when I click a gitlab.com or any other server I logged in link

@licaon-kter licaon-kter changed the title Add setting for open by default Add setting for "open by default" Oct 2, 2024
@mmarif4u
Copy link
Contributor

mmarif4u commented Oct 3, 2024

I think we are talking about something like deep links here.

For that, I will need to collect some data on the popular instances.

1- https://gitlab.com
2- https://framagit.org
3- https://dev.gajim.org
4- https://gitlab.alpinelinux.org
5- https://code.videolan.org
6- https://gitlab.xfce.org
7- https://invent.kde.org
8- https://gitlab.gnome.org

Please add other popular servers in the comments section.

@licaon-kter
Copy link
Author

I think we are talking about something like deep links here.

yes, but in the Android UI it's not called "deep links" :)

Please add other popular servers in the comments section.

about that, can these be added by the app, eg. I log with https://dev.gajim.org, can the app add this to the "open by default"?

Because this "feature" sounds more targeted to siloed sites that have one client, one domain. Eg. If self-host my Gitlab do I need to fork your app? That's dum- 🤷

@mmarif4u
Copy link
Contributor

mmarif4u commented Oct 3, 2024

yes, but in the Android UI it's not called "deep links" :)

Dayum... :)

Last time I checked this for GitNex, unfortunately, Android does not add anything to the Manifest file at runtime. To make this work, it has to be added before compiling.

If anyone knows another way to do this, I’m completely open to it.

Regarding adding instances, I’m fine with adding personal ones as well.

@ildar
Copy link

ildar commented Oct 14, 2024

I like the way LabCoat does it (though incomplete):

  1. use labcoat:// URL scheme for any gitlab instance.
  2. handle at least 1 well-known URL (gitlab.com)
  3. have some app to translate https://known.gitlab.instance to labcoat://known.gitlab.instance

The latter app has alternatives for now:

  1. https://gitlab.com/nomadlabs/deeplinks/
  2. total URL conversion TrianguloY/URLCheck#389

@mmarif4u mmarif4u changed the title Add setting for "open by default" Open links by default for issues and mr Oct 14, 2024
@mmarif4u
Copy link
Contributor

@ildar Thanks for your input.

I am personally not in favor of using another app for deep links. LabNex can handle that when implemented properly.

The LabCoat deeplinks app work the same way by adding domains to the Manifest file and opening them via the LabCoat URI to launch the LabCoat app.

That is the reason I asked to share as many popular links as possible here.

GitNex right now does this too.
https://codeberg.org/gitnex/GitNex/src/branch/main/app/src/main/AndroidManifest.xml#L203
https://codeberg.org/gitnex/GitNex/src/commit/9673def07ce9b9c8154471c6081cc907b76dfbc5/app/src/main/java/org/mian/gitnex/activities/DeepLinksActivity.java

I would be interested to know what they are doing differently without the Manifest file.

@ildar
Copy link

ildar commented Oct 14, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants