Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback workfrow #22

Open
tetienne opened this issue Feb 16, 2021 · 2 comments
Open

Add fallback workfrow #22

tetienne opened this issue Feb 16, 2021 · 2 comments

Comments

@tetienne
Copy link

Hi,

Many thanks for great project. I’m using the v2.

Is it possible to add a default workflow if a modified file does not match any of the packages defined in packages.json?

@dimadeveatii
Copy link
Member

dimadeveatii commented Mar 12, 2021

Hi @tetienne, thank you! We're using v2 as well and it works fine.

But what would be the usage of a fallback workflow? If you need a workflow that is just triggered on each change, you add one in CircleCI without parameter conditions (same as the ci workflow here).

@tetienne
Copy link
Author

In our monorepo, we have some files at the root of the repository, or even folders not in any packages such as .github or .circleci for instance.
So when a file in one of this folders is modified, it does not match any packages (in /packages/*), and no build are launched.

But few times after my question, I met an other issue with this script when I do some rebase interactive (git rebase -i) on a branch to squash or rename my commits. The script was totally lost, and does not detect any new modification on my branch.
I end up creating a similar script retrieving the modified files with the Github API: https://docs.github.com/en/rest/reference/pulls#list-pull-requests-files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants