Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rotation-correction branch incompatibility with current scikit-image version #233

Closed
dsudar opened this issue Jan 1, 2025 · 4 comments
Closed

Comments

@dsudar
Copy link

dsudar commented Jan 1, 2025

In utils.py the function register_angle() calls skimage.registration.phase_cross_correlation() with return_error as an argument. That argument is no longer accepted since scikit-image version 0.23. By default scikit-image 0.25 gets installed and that throws a runtime error when using the rotation-correction branch code which uses that function.

Simply removing that argument doesn't work since the return value of the ...phase_cross_correlation() function appears to have changed as well.

@jmuhlich
Copy link
Collaborator

It's a small fix, I can cherry-pick it from another branch here: jmuhlich@ded975f

@jmuhlich
Copy link
Collaborator

Sorry, I obviously wasn't reading/thinking clearly. The commit I linked above is in my rotation-correction branch! So it's already fixed -- I made the commit ~2 weeks after you caught this when I ran into it myself.

@dsudar
Copy link
Author

dsudar commented Feb 16, 2025

Yep, I noticed with your flurry of commits on 1/30, that this issue was resolved. But while the "new" rotation-correction branch runs fine, I find that on my data the stitching/registration-correction works much poorer than with an earlier version of that branch that I had forked in summer of 2023. Would you be interested to have a look at an example image?

@jmuhlich
Copy link
Collaborator

Of course!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants