Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Research if we could leverage the type system to prevent Eip712TransactionRequest.rlp calls when neither signature or custom_signature were provided. #101

Open
jpcenteno opened this issue Aug 28, 2023 · 0 comments
Open

Research if we could leverage the type system to prevent Eip712TransactionRequest.rlp calls when neither signature or custom_signature were provided. #101

jpcenteno opened this issue Aug 28, 2023 · 0 comments

Comments

@jpcenteno
Copy link
Contributor

This issue arrises from #92 which introduces an if statement which returns an error when neither signature or custom_signature were provided.

  • Is this necessary? Since Eip712TransactionRequest is actually a builder, spurious states should be temporarily accepted.
  • OTOH, it would be nice to provide a static check to prevent this error from happening.

I'm creating this issue just to remind ourselves to discuss this in the future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jpcenteno