Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix symbol names containing "eth" to disambiguate between the token and the Ethereum Layer 1 #106

Open
jpcenteno opened this issue Sep 1, 2023 · 0 comments

Comments

@jpcenteno
Copy link
Contributor

Currently, we have many symbol names containing the word eth referring to the Ethereum L1. ETH is the symbol for the Ether token, while Ethereum is the correct name for the network.

We should use something like l1 and l2 to refer to the blockchain layers, and use eth only when we are talking about the token.

As an example:

  • ZKSWallet.eth_balance() returns the ETH balance on the layer-1.
  • ZKSWallet.era_balance() returns the ETH balance for the layer-2.
  • ZKSWallet.eth_provider is a layer-1 middleware, not something that provides Ether.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant