Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Ensure that we check, build and test code examples #118

Open
5 tasks
jpcenteno opened this issue Sep 14, 2023 · 0 comments
Open
5 tasks

[ci] Ensure that we check, build and test code examples #118

jpcenteno opened this issue Sep 14, 2023 · 0 comments
Labels
CI、 test and checking Automated quality checks

Comments

@jpcenteno
Copy link
Contributor

jpcenteno commented Sep 14, 2023 •
edited
Loading

Why?

As @fkrause98 mentioned:

Maybe out of the scope of this PR but we should add a CI step to check this and future examples compile with: cargo build --examples ...
Originally posted by @fkrause98 in #117 (comment)

Requirements

  • Ensure cargo fmt -- --check includes the examples/ dir. Is the --all flag the answer?
  • Are we using clippy yet?
  • Build every test. Is there a flag for this purpose? Or do we need some extra steps?
  • Can we use assertions in the examples so we can run them as if they were integration or regression tests?
  • Any other automated QA step I forgot?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI、 test and checking Automated quality checks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jpcenteno