Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that two MethodGenerator instances hold metadata for methods with the same signature #14

Closed
weierophinney opened this issue Dec 31, 2019 · 1 comment
Assignees
Labels
Question Further information is requested Won't Fix This will not be worked on

Comments

@weierophinney
Copy link
Member

Suppose I have two MethodGenerator instances - $methodA and $methodB.
Does this library provide a way to check, whether methods, that might be generated by $methodA and $methodB will have the same signature?
By the same signature I mean identical method names, same params with same type hints and same return types.
I thought there might be method like MethodGenerator::hasSameSignature(MethodGenerator $method) but I don't see anything like that in the class API.

I think it would be a very helpful feature, since for decorating class methods it's necessary to check that generated method has the same signature as existing one.


Originally posted by @petr-buchin at zendframework/zend-code#108

@Ocramius
Copy link
Member

This library does indeed not provide such functionality: would be best to request such a feature on https://github.com/Roave/BetterReflection instead

@Ocramius Ocramius added the Question Further information is requested label Nov 30, 2020
@Ocramius Ocramius self-assigned this Nov 30, 2020
@Ocramius Ocramius added the Won't Fix This will not be worked on label Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Question Further information is requested Won't Fix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants