-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promoted properties are losing nullable flag #183
Labels
Bug
Something isn't working
Comments
Grundik
added a commit
to Grundik/laminas-code
that referenced
this issue
May 16, 2023
Signed-off-by: Grundik <[email protected]>
Grundik
added a commit
to Grundik/laminas-code
that referenced
this issue
May 16, 2023
Signed-off-by: Grundik <[email protected]>
Possible fix: #184 |
Grundik
added a commit
to Grundik/laminas-code
that referenced
this issue
May 16, 2023
Signed-off-by: Grundik <[email protected]>
Grundik
added a commit
to Grundik/laminas-code
that referenced
this issue
May 16, 2023
Signed-off-by: Grundik <[email protected]>
Grundik
added a commit
to Grundik/laminas-code
that referenced
this issue
May 16, 2023
Signed-off-by: Grundik <[email protected]>
Grundik
added a commit
to Grundik/laminas-code
that referenced
this issue
May 16, 2023
Signed-off-by: Grundik <[email protected]>
Grundik
added a commit
to Grundik/laminas-code
that referenced
this issue
May 16, 2023
Signed-off-by: Grundik <[email protected]>
Grundik
added a commit
to Grundik/laminas-code
that referenced
this issue
May 16, 2023
Signed-off-by: Grundik <[email protected]>
Grundik
added a commit
to Grundik/laminas-code
that referenced
this issue
May 16, 2023
Signed-off-by: Grundik <[email protected]>
Grundik
added a commit
to Grundik/laminas-code
that referenced
this issue
May 16, 2023
Signed-off-by: Grundik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Report
Summary
Laminas\Code\Generator\PromotedParameterGenerator#fromParameterGeneratorWithVisibility are losing nullable flag of such parameter.
Current behavior
will echo
protected int $value
, nullable flag is lost.How to reproduce
Use snippet above.
Expected behavior
Code above should echo
protected ?int $value
.Additional information
https://github.com/laminas/laminas-code/blob/169123b3ede20a9193480c53de2a8194f8c073ec/src/Generator/PromotedParameterGenerator.php#LL73C51-L73C51
Unfortunately, there are no way to get nullable flag from TypeGenerator at all for now. Unsurprisingly it get lost on the way.
The text was updated successfully, but these errors were encountered: