Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zend\Code\Reflection\FileReflection getBody() #9

Closed
weierophinney opened this issue Dec 31, 2019 · 1 comment · Fixed by #58
Closed

Zend\Code\Reflection\FileReflection getBody() #9

weierophinney opened this issue Dec 31, 2019 · 1 comment · Fixed by #58
Assignees
@Ocramius
Labels
Bug Something isn't working Won't Fix This will not be worked on
Milestone
4.0.0

Comments

@weierophinney
Copy link
Member

When instantiating a Zend\Code\Generator\FileGenerator::fromReflection() one would expect ::generate to fully reconstruct any original file. Unfortunately Zend\Code\Reflection\FileReflection has no ::getBody method so any code outside classes is ignored.

Originally posted by @BavoJanss at zendframework/zend-code#141
@weierophinney weierophinney mentioned this issue Dec 31, 2019
Open
@Ocramius
Copy link
Member

No longer needed as per #58

@Ocramius Ocramius added Bug Something isn't working Won't Fix This will not be worked on labels Nov 30, 2020
@Ocramius Ocramius linked a pull request Nov 30, 2020 that will close this issue
BC BREAK: removed Scanner component, removed FileReflection, removed NameInformation and made DocBlockScanner @internal #58
Merged
2 tasks
@Ocramius Ocramius self-assigned this Nov 30, 2020
@Ocramius Ocramius added this to the 4.0.0 milestone Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ocramius Ocramius

Labels
Bug Something isn't working Won't Fix This will not be worked on
Projects
None yet
Milestone
4.0.0
2 participants
@weierophinney @Ocramius