Incorrect Sql Expression parameters when passing zero in the constructor

[weierophinney]

• I was not able to find an open or closed issue matching what I'm seeing.
• This is not a question. (Questions should be asked on slack (Signup for Slack here) or our forums.)

I am trying to create an expression that has zero as the parameter value. However, the parameters incorrectly show as empty.

Code to reproduce the issue

$expr = new \Zend\Db\Sql\Expression('?', '0');
print_r($expr->getParameters());

Expected results

It prints "0"

Actual results

It prints empty array

Proposed fix

https://github.com/zendframework/zend-db/blob/master/src/Sql/Expression.php#L59

In Zend\Db\Sql\Expression, update the constructor to explicitly check for '0' when setting parameters

if ($parameters || $parameters === '0') {
     $this->setParameters($parameters);
}

---

Originally posted by @albertor24 at zendframework/zend-db#381

[weierophinney]

@albertor24 Please submit PR and add test to cover your case 👍

---

Originally posted by @michalbundyra at zendframework/zend-db#381 (comment)

[samsonasik]

I seems already fixed. I tried it:

➜  laminas-db git:(master) php -a
Interactive shell

php > include 'vendor/autoload.php';
php > $expr = new \Zend\Db\Sql\Expression('?', '0');
php > print_r($expr->getParameters());
0

I'm closing it.