Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated Review problem #4

Open
akhileshkumargangwar opened this issue Aug 29, 2018 · 9 comments
Open

Generated Review problem #4

akhileshkumargangwar opened this issue Aug 29, 2018 · 9 comments

Comments

@akhileshkumargangwar
Copy link

I want to ask how data is splitted into postive and negative reviews.When I checked manually many reviews whose score is 1 or 2 has been assigned to positive folder (discriminator_train/positive).Logically it is negative review.
After adversial training in this (train_sample_generated/7epoch_step2_temp_positive/000012.txt) file generated review is just copy of original given review.
Orginal Input Review-- {"review": "i wasnt thrilled with the taste of the food compared to how pricy it is . i would have enjoyed a juicy steak somewhere else . however i do like the romance of fondue", "score": "3"}
Generated Review in file 000012.txt---{"label": "1", "example": "i would have enjoyed a juicy steak somewhere else . however i do like the romance of fondue"}

It has just reduced one sentence. Is it like that.

@jingjingxupku
Copy link
Collaborator

jingjingxupku commented Aug 30, 2018

"discriminator_train/positive" stores the real data. "discriminator_train/negative" stores the data generated by our code. It is important to note that "positive/negative" means the positive samples and negative samples for discriminator, rather than favourable/disapproving comments.

@akhileshkumargangwar
Copy link
Author

Thank You,
please give some hint about my second question.

@jingjingxupku
Copy link
Collaborator

jingjingxupku commented Aug 30, 2018

train_sample_generated/7epoch_step2_temp_positive/000012.txt is not the generated data. It is the copy of original reviews to show what the real-life reviews should be. If you want to see the generated data, please open the folder "train_sample_generated/7epoch_step2_temp_negative/000012.txt".

@akhileshkumargangwar
Copy link
Author

Thank You,
Your code is very good and has used text data as input. I am confused with positive, negative terms. Thanks to make your code publicly available. May you please give some description in readme about which generated folders contains what.Many folders has been generated and how to find corresponding input to generated output. Your code is good compare to other available code like SeqGAN and others. It will be helpful for novice researchers.

@jingjingxupku
Copy link
Collaborator

jingjingxupku commented Aug 30, 2018

I will add more folder descriptions in readme.md soon. Thank you for your suggestion!

@akhileshkumargangwar
Copy link
Author

Please add folder description

@jingjingxupku
Copy link
Collaborator

Sorry for the delay. I will upload the folder description in 24 hours.

@akhileshkumargangwar
Copy link
Author

Thanks for updating Readme

@mambalong
Copy link

@akhileshkumargangwar How long does it take to run the code? I run the code by running the "run.sh" file. It has been 24 hours now, it is still running. And I am using a GPU.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants