Use mysql command for MariaDB 10.3.x and below (#53)

Author: uberhacker

.github/workflows/pr-symfony-tests.yml

@@ -20,6 +20,7 @@ jobs:
           - examples/symfony-import
           - examples/symfony-init
           - examples/symfony-mariadb
+          - examples/symfony-mariadb-mysql
           - examples/symfony-mysql8
           - examples/symfony-nginx
         lando-version:

CHANGELOG.md

@@ -1,7 +1,6 @@
 ## {{ UNRELEASED_VERSION }} - [{{ UNRELEASED_DATE }}]({{ UNRELEASED_LINK }})
 
-* Updated mariadb plugin [#51](https://github.com/lando/mariadb/issues/51)
-* Cleaned up test comments
+* Use mysql command for MariaDB 10.3.x and below [#52](https://github.com/lando/symfony/issues/52)
 
 ## v1.5.0 - [March 8, 2024](https://github.com/lando/symfony/releases/tag/v1.5.0)
 

builders/symfony.js

@@ -133,15 +133,19 @@ const toolingDefaults = {
 */
 const getDbTooling = database => {
   // Make sure we strip out any version number
-  database = database.split(':')[0];
+  const db = database.split(':')[0];
+  const ver = database.split(':')[1];
   // Choose wisely
-  if (database === 'mysql') {
+  if (db === 'mysql') {
     return {mysql: mysqlCli};
-  } else if (database === 'mariadb') {
+  } else if (db === 'mariadb' && ver < 10.4) {
+    // mariadb command not available in 10.3.x and below
+    return {mysql: mysqlCli};
+  } else if (db === 'mariadb') {
     return {mariadb: mariadbCli};
-  } else if (database === 'postgres') {
+  } else if (db === 'postgres') {
     return {psql: postgresCli};
-  } else if (database === 'mongo') {
+  } else if (db === 'mongo') {
     return {mongo: {
       service: 'database',
       description: 'Drop into the mongo shell',
@@ -225,7 +229,6 @@ const getConfigDefaults = options => {
 */
 const getTooling = options => _.merge({}, toolingDefaults, getDbTooling(options.database));
 
-
 /*
 * Build Symfony
 */

examples/symfony-mariadb-mysql/.lando.yml

@@ -0,0 +1,10 @@
+name: symfony-mariadb-mysql
+recipe: symfony
+config:
+  webroot: web
+  php: 8.3
+  database: mariadb:10.3
+
+# do not remove this
+plugins:
+  "@lando/symfony": ../..

examples/symfony-mariadb-mysql/README.md

@@ -0,0 +1,56 @@
+# Symfony MariaDB/MySQL Example
+
+This example exists primarily to test the following documentation:
+
+* [Symfony Recipe](https://docs.lando.dev/symfony/config.html)
+
+Versions of MariaDB 10.3.x and lower do not have the mariadb command and must use the mysql executable.
+
+Start up tests
+--------------
+
+Run the following commands to get up and running with this example.
+
+```bash
+# Should start up successfully
+lando poweroff
+lando start
+```
+
+Verification commands
+---------------------
+
+Run the following commands to validate things are rolling as they should.
+
+```bash
+# Should serve from web folder
+lando ssh -s appserver -c "curl -L localhost" | grep "MySQL"
+
+# Should be running apache 2.4 by default
+lando ssh -s appserver -c "apachectl -V | grep 2.4"
+lando ssh -s appserver -c "curl -IL localhost" | grep Server | grep 2.4
+
+# Should use php 8.3 if specified by user
+lando php -v | grep "PHP 8.3."
+
+# Should be running mariadb 10.3.x if specified by user
+lando mysql -V | grep "MariaDB" | grep "10.3."
+
+# Should be able to connect to the database with the default creds
+lando mysql symfony -e quit
+
+# Should use the default mariadb config file
+lando ssh -s database -c "cat /opt/bitnami/mariadb/conf/my_custom.cnf" | grep "innodb_lock_wait_timeout = 121"
+lando mysql -u root -e "show variables;" | grep innodb_lock_wait_timeout | grep 121
+```
+
+Destroy tests
+-------------
+
+Run the following commands to trash this app like nothing ever happened.
+
+```bash
+# Should be destroyed with success
+lando destroy -y
+lando poweroff
+```

examples/symfony-mariadb-mysql/web/index.php

@@ -0,0 +1 @@
+MySQL

examples/symfony-mariadb-mysql/web/info.php

@@ -0,0 +1 @@
+<?php phpinfo(); ?>