Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structure of project #15

Open
davenquinn opened this issue May 29, 2020 · 0 comments
Open

Structure of project #15

davenquinn opened this issue May 29, 2020 · 0 comments

Comments

@davenquinn
Copy link

Hi — this is a very interesting looking project, and I suppose my issue is a bit of a meta-comment, related to #3.

The structure of the project (a fork the base Mapbox-GL JS codebase) seems to get in the way of its continued usability and maintainability. It's hard to get a sense as a potential user/outside contributor as to what parts have been changed from the base Mapbox codebase.

Is it feasible to restructure this project as a module with a dependency on Mapbox GL? Even if it uses non-public APIs, keeping the codebases separate would be a major win, even if the Mapbox GL version has to be pinned or included as a submodule. It would make it much more tractable for the purposes of external contributions. Relatedly, changing the module ID could allow this and the first-party Mapbox GL to exist side-by-side in the same codebase, if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant