Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When all planet fields are used no buildings should be able to be built anymore #393

Open
2 tasks
lanedirt opened this issue Oct 14, 2024 · 0 comments
Open
2 tasks
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@lanedirt
Copy link
Owner

lanedirt commented Oct 14, 2024

PR #390 added logic to calculate the amount of used fields on a planet.

When all fields on a planet are used up the building or upgrading of buildings should be disabled. I am not sure yet what it looks like in the official game when a planet is actually full. But we could start by disallowing the upgrade via a server-side exception and improve it with the proper client-side state/warnings later.

Help wanted:
If someone knows what the official game shows when a planet is full feel free to comment.

Todo:

  • Add check if all planet fields are used. If so, disallow the building or upgrading of buildings.
  • This also applies to moons when Add moons #423 is merged. Moons show a warning message when the last field on a planet/moon will be used up by building the next object. Planets will probably need to show the same message.

Further notes:

@lanedirt lanedirt added enhancement New feature or request help wanted Extra attention is needed labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant