Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove regex validation for index_name #44

Merged
merged 4 commits into from
Dec 6, 2024

Conversation

harupy
Copy link
Collaborator

@harupy harupy commented Dec 5, 2024

Only validate index_name is a string.

@harupy harupy changed the title Remove validation for index_name Remove regex validation for index_name Dec 5, 2024
@harupy harupy requested a review from B-Step62 December 5, 2024 10:56
Copy link
Contributor

@prithvikannan prithvikannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@harupy harupy merged commit 0aa4d60 into langchain-ai:main Dec 6, 2024
8 checks passed
@harupy harupy deleted the remove-validation branch December 6, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants