code migration to community #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkuligin
force-pushed
the
migration2
branch
2 times, most recently
from
78752fa to
9ec9c4e
Compare
svidiella
reviewed
Mar 26, 2024
Comment on lines
+63
to
+69
| try: | ||
| from google.cloud import storage # type: ignore[attr-defined] | ||
| except ImportError: | ||
| raise ImportError( | ||
| "Could not import google-cloud-storage python package. " | ||
| "Please install it with `pip install google-cloud-storage`." | ||
| ) |
There was a problem hiding this comment.
Why not adding this as poetry dependencies instead of loading dependencies this way?
There was a problem hiding this comment.
that might be the next step, but we need to create separate groups.
we don't want to bring all dependencies together as a requirements for the package.
svidiella
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.