Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vanity model name support #35

Merged
merged 7 commits into from
May 7, 2024
Merged

vanity model name support #35

merged 7 commits into from
May 7, 2024

Conversation

mattf
Copy link
Collaborator

@mattf mattf commented May 3, 2024

model names are currently things like playground_llama2-70b or ai-llama3-70b, these are not the proper names for the models. ai-llama3-70b is the name of a cloud function that serves the meta/llama3-70b-instruct model.

with this change the proper model names can be used along side the function name, for compatibility.

llm = ChatNVIDIA(model="ai-llama3-70b")

is equivalent to

llm = ChatNVIDIA(model="meta/llama3-70b-instruct")

@mattf mattf marked this pull request as draft May 3, 2024 20:06
@mattf mattf force-pushed the mattf/vanity-name-support branch from b325349 to ddfeda1 Compare May 3, 2024 20:27
@mattf mattf self-assigned this May 3, 2024
@mattf mattf requested review from raspawar and rlokhande-nv May 6, 2024 12:56
Copy link
Collaborator

@rlokhande-nv rlokhande-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mattf mattf marked this pull request as ready for review May 6, 2024 17:10
@mattf mattf merged commit 7236915 into main May 7, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants