From 183daa6e6fe11880728842ef2b54cc3c44e6f564 Mon Sep 17 00:00:00 2001
From: Sandeep Banerjee <sandeepbanerjee253@gmail.com>
Date: Sat, 10 Feb 2024 07:30:24 +0530
Subject: [PATCH] google-genai[patch]: on_llm_new_token fix (#16924)

### This pull request makes the following changes:
* Fixed issue #16913

Fixed the google gen ai chat_models.py code to make sure that the
callback is called before the token is yielded

<!-- Thank you for contributing to LangChain!

Please title your PR "<package>: <description>", where <package> is
whichever of langchain, community, core, experimental, etc. is being
modified.

Replace this entire comment with:
  - **Description:** a description of the change,
  - **Issue:** the issue # it fixes if applicable,
  - **Dependencies:** any dependencies required for this change,
- **Twitter handle:** we announce bigger features on Twitter. If your PR
gets announced, and you'd like a mention, we'll gladly shout you out!

Please make sure your PR is passing linting and testing before
submitting. Run `make format`, `make lint` and `make test` from the root
of the package you've modified to check this locally.

See contribution guidelines for more information on how to write/run
tests, lint, etc: https://python.langchain.com/docs/contributing/

If you're adding a new integration, please include:
1. a test for the integration, preferably unit tests that do not rely on
network access,
2. an example notebook showing its use. It lives in
`docs/docs/integrations` directory.

If no one reviews your PR within a few days, please @-mention one of
@baskaryan, @eyurtsev, @hwchase17.
 -->

---------

Co-authored-by: Erick Friis <erick@langchain.dev>
---
 .../partners/google-genai/langchain_google_genai/chat_models.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libs/partners/google-genai/langchain_google_genai/chat_models.py b/libs/partners/google-genai/langchain_google_genai/chat_models.py
index 420dbcfd13595..496f54add5513 100644
--- a/libs/partners/google-genai/langchain_google_genai/chat_models.py
+++ b/libs/partners/google-genai/langchain_google_genai/chat_models.py
@@ -598,6 +598,7 @@ def _stream(
         for chunk in response:
             _chat_result = _response_to_result(chunk, stream=True)
             gen = cast(ChatGenerationChunk, _chat_result.generations[0])
+
             if run_manager:
                 run_manager.on_llm_new_token(gen.text)
             yield gen
@@ -622,6 +623,7 @@ async def _astream(
         ):
             _chat_result = _response_to_result(chunk, stream=True)
             gen = cast(ChatGenerationChunk, _chat_result.generations[0])
+
             if run_manager:
                 await run_manager.on_llm_new_token(gen.text)
             yield gen