Skip to content

Commit

Permalink
openai[patch]: default temp=1 for o1 (#27206)
Browse files Browse the repository at this point in the history
  • Loading branch information
baskaryan authored Oct 8, 2024
1 parent b298d03 commit ce33c4f
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 0 deletions.
9 changes: 9 additions & 0 deletions libs/partners/openai/langchain_openai/chat_models/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -480,6 +480,15 @@ def build_extra(cls, values: Dict[str, Any]) -> Any:
values = _build_model_kwargs(values, all_required_field_names)
return values

@model_validator(mode="before")
@classmethod
def validate_temperature(cls, values: Dict[str, Any]) -> Any:
"""Currently o1 models only allow temperature=1."""
model = values.get("model_name") or values.get("model") or ""
if model.startswith("o1") and "temperature" not in values:
values["temperature"] = 1
return values

@model_validator(mode="after")
def validate_environment(self) -> Self:
"""Validate that api key and python package exists in environment."""
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,13 @@ def test_openai_model_param() -> None:
assert llm.model_name == "foo"


def test_openai_o1_temperature() -> None:
llm = ChatOpenAI(model="o1-preview")
assert llm.temperature == 1
llm = ChatOpenAI(model_name="o1-mini") # type: ignore[call-arg]
assert llm.temperature == 1


def test_function_message_dict_to_function_message() -> None:
content = json.dumps({"result": "Example #1"})
name = "test_function"
Expand Down

0 comments on commit ce33c4f

Please sign in to comment.