Skip to content

Commit

Permalink
community[patch]: fix dashvector endpoint params error (#14484)
Browse files Browse the repository at this point in the history
<!-- Thank you for contributing to LangChain!

Replace this entire comment with:
  - **Description:** a description of the change, 
  - **Issue:** the issue # it fixes (if applicable),
  - **Dependencies:** any dependencies required for this change,
- **Tag maintainer:** for a quicker response, tag the relevant
maintainer (see below),
- **Twitter handle:** we announce bigger features on Twitter. If your PR
gets announced, and you'd like a mention, we'll gladly shout you out!

Please make sure your PR is passing linting and testing before
submitting. Run `make format`, `make lint` and `make test` to check this
locally.

See contribution guidelines for more information on how to write/run
tests, lint, etc:

https://github.com/langchain-ai/langchain/blob/master/.github/CONTRIBUTING.md

If you're adding a new integration, please include:
1. a test for the integration, preferably unit tests that do not rely on
network access,
2. an example notebook showing its use. It lives in `docs/extras`
directory.

If no one reviews your PR within a few days, please @-mention one of
@baskaryan, @eyurtsev, @hwchase17.
 -->

Co-authored-by: fangkeke <[email protected]>
Co-authored-by: Harrison Chase <[email protected]>
  • Loading branch information
3 people authored Dec 13, 2023
1 parent dce3c74 commit ea99612
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion libs/community/langchain_community/vectorstores/dashvector.py
Original file line number Diff line number Diff line change
Expand Up @@ -309,6 +309,7 @@ def from_texts(
embedding: Embeddings,
metadatas: Optional[List[dict]] = None,
dashvector_api_key: Optional[str] = None,
dashvector_endpoint: Optional[str] = None,
collection_name: str = "langchain",
text_field: str = "text",
batch_size: int = 25,
Expand Down Expand Up @@ -345,7 +346,14 @@ def from_texts(
"dashvector_api_key", "DASHVECTOR_API_KEY"
)

dashvector_client = dashvector.Client(api_key=dashvector_api_key)
dashvector_endpoint = dashvector_endpoint or get_from_env(
"dashvector_endpoint",
"DASHVECTOR_ENDPOINT",
default="dashvector.cn-hangzhou.aliyuncs.com",
)
dashvector_client = dashvector.Client(
api_key=dashvector_api_key, endpoint=dashvector_endpoint
)
dashvector_client.delete(collection_name)
collection = dashvector_client.get(collection_name)
if not collection:
Expand Down

0 comments on commit ea99612

Please sign in to comment.