LocalFileStore
should support a shared CacheBackedEmbeddings
for multiple users
#18075
Closed
chrispy-snps
started this conversation in
Ideas
Replies: 2 comments
-
I filed #18077 to implement this. |
Beta Was this translation helpful? Give feedback.
0 replies
-
I don't think we want to extend functionality for the local file store. it's mostly there as a reference implementation / for easy prototyping locally. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Checked
Feature request
The
LocalFileStore
class can be used to create an on-disk embedding cache. However, the defaultumask
settings gives file/directory write perrmissions only to the original user. Once the cache directory is created, other users cannot write their own cache entries into the directory.To make the cache usable by multiple users, the
LocalFileStore
constructor should accept aumask
parameter that is used for file/directory creation.Motivation
We would like to share a
CacheBackedEmeddings
store between a small number of users. This enhancement would allow the following:umask
of0o007
(user and group permitted, others masked), anyone in our group can contribute embeddings to the cache.Proposal (If applicable)
Update the
LocalFileStore
class to accept aumask
parameter that is used for file/directory creation. If theumask
parameter is not specified, the default behavior should be unchanged from today's behavior.Beta Was this translation helpful? Give feedback.
All reactions