ConversationalRetrievalChain new_question only from the question_generator only for retrieval and not for combine_docs_chain

[lucasiscovici]

Hello and thank you for this amazing library.

Here we :

• get question
• get new_question with the question_generator
• retrieve docs with _get_docs and the new_question
• call the combine_docs_chain with the new_question and the docs

1/ It's possible to allow to call the question_generator event if the chat_history_str is empty ?
i have to transform the question to search query to call the search engine even if the chat history is empty

2/ It's possible to not use the new_question in the combine_docs_chain call ?
i need the true question and not the new question (the search query) to call the llm for the qa

Thanks in advance

    def _call(
        self,
        inputs: Dict[str, Any],
        run_manager: Optional[CallbackManagerForChainRun] = None,
    ) -> Dict[str, Any]:
        _run_manager = run_manager or CallbackManagerForChainRun.get_noop_manager()
        question = inputs["question"]
        get_chat_history = self.get_chat_history or _get_chat_history
        chat_history_str = get_chat_history(inputs["chat_history"])

        if chat_history_str:
            callbacks = _run_manager.get_child()
            new_question = self.question_generator.run(
                question=question, chat_history=chat_history_str, callbacks=callbacks
            )
        else:
            new_question = question
        docs = self._get_docs(new_question, inputs)
        new_inputs = inputs.copy()
        new_inputs["question"] = new_question
        new_inputs["chat_history"] = chat_history_str
        answer = self.combine_docs_chain.run(
            input_documents=docs, callbacks=_run_manager.get_child(), **new_inputs
        )
        if self.return_source_documents:
            return {self.output_key: answer, "source_documents": docs}
        else:
            return {self.output_key: answer}

[ARSblithe212]

you can realize your chain, rewrite the _call function。