Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persist method in Chroma no longer exists in Chroma 0.4.x #20851

Closed
5 tasks done
AndresAlgaba opened this issue Apr 24, 2024 · 1 comment
Closed
5 tasks done

Persist method in Chroma no longer exists in Chroma 0.4.x #20851

AndresAlgaba opened this issue Apr 24, 2024 · 1 comment
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature 🔌: chroma Primarily related to ChromaDB integrations Ɑ: vector store Related to vector store module

Comments

@AndresAlgaba
Copy link
Contributor

Checked other resources

  • I added a very descriptive title to this issue.
  • I searched the LangChain documentation with the integrated search.
  • I used the GitHub search to find a similar question and didn't find it.
  • I am sure that this is a bug in LangChain rather than my code.
  • The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code

from langchain_chroma import Chroma
db = Chroma()
db.persist()

Error Message and Stack Trace (if applicable)

AttributeError: 'Chroma' object has no attribute 'persist'

Description

I saw in a langchain-related issue on the Chroma GitHub page that they mention that in Chroma 0.4.x, the persist method no longer exists: chroma-core/chroma#2012 (comment)

Therefore, I believe it should also be removed here:

langchain/libs/community/langchain_community/vectorstores/chroma.py

Line 613 in 87d31a3

def persist(self) -> None:

System Info

System Information

OS: Darwin
OS Version: Darwin Kernel Version 23.4.0: Fri Mar 15 00:10:42 PDT 2024; root:xnu-10063.101.17~1/RELEASE_ARM64_T6000
Python Version: 3.9.11 (v3.9.11:2de452f8bf, Mar 16 2022, 10:44:40)
[Clang 13.0.0 (clang-1300.0.29.30)]

Package Information

langchain_core: 0.1.45
langchain: 0.1.16
langchain_community: 0.0.34
langsmith: 0.1.49
langchain_chroma: 0.1.0
langchain_text_splitters: 0.0.1
langchainhub: 0.1.15

Packages not installed (Not Necessarily a Problem)

The following packages were not found:

langgraph
langserve
@dosubot dosubot bot added Ɑ: vector store Related to vector store module 🔌: chroma Primarily related to ChromaDB integrations 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Apr 24, 2024
@AndresAlgaba AndresAlgaba mentioned this issue Apr 24, 2024
Merged
4 tasks
baskaryan added a commit that referenced this issue Apr 25, 2024
@AndresAlgaba @baskaryan
community[patch]: deprecate persist method in Chroma (#20855)
05ae8ca 
Thank you for contributing to LangChain!

- [x] **PR title**

- [x] **PR message**:
- **Description:** Deprecate persist method in Chroma no longer exists
in Chroma 0.4.x
    - **Issue:** #20851 
    - **Dependencies:** None
    - **Twitter handle:** AndresAlgaba1

- [x] **Add tests and docs**: If you're adding a new integration, please
include
1. a test for the integration, preferably unit tests that do not rely on
network access,
2. an example notebook showing its use. It lives in
`docs/docs/integrations` directory.

- [x] **Lint and test**: Run `make format`, `make lint` and `make test`
from the root of the package(s) you've modified. See contribution
guidelines for more: https://python.langchain.com/docs/contributing/

---------

Co-authored-by: Bagatur <[email protected]>
hinthornw pushed a commit that referenced this issue Apr 26, 2024
@AndresAlgaba @baskaryan @hinthornw
community[patch]: deprecate persist method in Chroma (#20855)
630dba7 
Thank you for contributing to LangChain!

- [x] **PR title**

- [x] **PR message**:
- **Description:** Deprecate persist method in Chroma no longer exists
in Chroma 0.4.x
    - **Issue:** #20851 
    - **Dependencies:** None
    - **Twitter handle:** AndresAlgaba1

- [x] **Add tests and docs**: If you're adding a new integration, please
include
1. a test for the integration, preferably unit tests that do not rely on
network access,
2. an example notebook showing its use. It lives in
`docs/docs/integrations` directory.

- [x] **Lint and test**: Run `make format`, `make lint` and `make test`
from the root of the package(s) you've modified. See contribution
guidelines for more: https://python.langchain.com/docs/contributing/

---------

Co-authored-by: Bagatur <[email protected]>
@AndresAlgaba
Copy link
Contributor Author

Fixed in #20855

pprados pushed a commit to pprados/langchain that referenced this issue Apr 26, 2024
@AndresAlgaba @baskaryan @pprados
community[patch]: deprecate persist method in Chroma (langchain-ai#20855
b0d7bab 
)

Thank you for contributing to LangChain!

- [x] **PR title**

- [x] **PR message**:
- **Description:** Deprecate persist method in Chroma no longer exists
in Chroma 0.4.x
    - **Issue:** langchain-ai#20851 
    - **Dependencies:** None
    - **Twitter handle:** AndresAlgaba1

- [x] **Add tests and docs**: If you're adding a new integration, please
include
1. a test for the integration, preferably unit tests that do not rely on
network access,
2. an example notebook showing its use. It lives in
`docs/docs/integrations` directory.

- [x] **Lint and test**: Run `make format`, `make lint` and `make test`
from the root of the package(s) you've modified. See contribution
guidelines for more: https://python.langchain.com/docs/contributing/

---------

Co-authored-by: Bagatur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature 🔌: chroma Primarily related to ChromaDB integrations Ɑ: vector store Related to vector store module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AndresAlgaba