partner: Update aiohttp in langchain pinecone. #28863
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
ashvin-a
changed the title
ccurme
reviewed
Dec 23, 2024
There was a problem hiding this comment.
Thanks for this.
I'm not sure this is a simple change unfortunately. aiohttp is still on version 3.9.5 in the lock file, so CI is running with that version. Could you poetry update aiohttp to install a 3.10 version and debug from there?
I started this in a branch here if you want to compare but would welcome any suggestions/fixes on this branch as well. We might need to introduce a breaking change in langchain-pinecone to address this; if so we should be careful to do it in a way that minimizes pain for users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partner: "Update Aiohttp for resolving vulnerability issue"
3.10to3.10.5in the pyproject.toml file of langchain-pinecone. Hopefully this will resolve Vulnerability issue in langchain-pinecone 0.2.0 (https://github.com/advisories/GHSA-jwhx-xcg6-8xhj) #28771 . Please review this as I'm quite unsure.