From 9cc88b0bd07f1501b5e0803a63bc2a0e26a39b52 Mon Sep 17 00:00:00 2001 From: calvinweb <38599774+calvinweb@users.noreply.github.com> Date: Sat, 10 Feb 2024 14:25:21 +0800 Subject: [PATCH 1/8] Let huggingface llm don't repeat prompt --- libs/community/langchain_community/llms/huggingface_hub.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libs/community/langchain_community/llms/huggingface_hub.py b/libs/community/langchain_community/llms/huggingface_hub.py index 2d91231775231..36b92995386ec 100644 --- a/libs/community/langchain_community/llms/huggingface_hub.py +++ b/libs/community/langchain_community/llms/huggingface_hub.py @@ -127,7 +127,7 @@ def _call( response = hf("Tell me a joke.") """ _model_kwargs = self.model_kwargs or {} - parameters = {**_model_kwargs, **kwargs} + parameters = {**_model_kwargs, **kwargs, "return_full_text":False} response = self.client.post( json={"inputs": prompt, "parameters": parameters}, task=self.task From 721ec2e2a55620b5b139f16e5c1bf39646d2f3cb Mon Sep 17 00:00:00 2001 From: calvinweb <38599774+calvinweb@users.noreply.github.com> Date: Sat, 10 Feb 2024 14:38:29 +0800 Subject: [PATCH 2/8] Update huggingface_hub.py --- libs/community/langchain_community/llms/huggingface_hub.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libs/community/langchain_community/llms/huggingface_hub.py b/libs/community/langchain_community/llms/huggingface_hub.py index 36b92995386ec..5f39e258c4785 100644 --- a/libs/community/langchain_community/llms/huggingface_hub.py +++ b/libs/community/langchain_community/llms/huggingface_hub.py @@ -127,7 +127,7 @@ def _call( response = hf("Tell me a joke.") """ _model_kwargs = self.model_kwargs or {} - parameters = {**_model_kwargs, **kwargs, "return_full_text":False} + parameters = {**_model_kwargs, **kwargs, "return_full_text": False} response = self.client.post( json={"inputs": prompt, "parameters": parameters}, task=self.task From 2f8494178d930888c087f184292b8baf1ffa7087 Mon Sep 17 00:00:00 2001 From: calvinweb <38599774+calvinweb@users.noreply.github.com> Date: Sun, 11 Feb 2024 17:42:20 +0800 Subject: [PATCH 3/8] put `return_full_text` the first item so that user can change it --- libs/community/langchain_community/llms/huggingface_hub.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libs/community/langchain_community/llms/huggingface_hub.py b/libs/community/langchain_community/llms/huggingface_hub.py index 5f39e258c4785..8a7540cf2e98a 100644 --- a/libs/community/langchain_community/llms/huggingface_hub.py +++ b/libs/community/langchain_community/llms/huggingface_hub.py @@ -127,7 +127,7 @@ def _call( response = hf("Tell me a joke.") """ _model_kwargs = self.model_kwargs or {} - parameters = {**_model_kwargs, **kwargs, "return_full_text": False} + parameters = {"return_full_text": False**_model_kwargs, **kwargs, "return_full_text": False} response = self.client.post( json={"inputs": prompt, "parameters": parameters}, task=self.task From 8edba455fe897140cd6e368458b3be13221e9a51 Mon Sep 17 00:00:00 2001 From: calvinweb <38599774+calvinweb@users.noreply.github.com> Date: Mon, 12 Feb 2024 13:04:52 +0800 Subject: [PATCH 4/8] Fix a typo --- libs/community/langchain_community/llms/huggingface_hub.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libs/community/langchain_community/llms/huggingface_hub.py b/libs/community/langchain_community/llms/huggingface_hub.py index 8a7540cf2e98a..3084b75d42f4c 100644 --- a/libs/community/langchain_community/llms/huggingface_hub.py +++ b/libs/community/langchain_community/llms/huggingface_hub.py @@ -127,7 +127,7 @@ def _call( response = hf("Tell me a joke.") """ _model_kwargs = self.model_kwargs or {} - parameters = {"return_full_text": False**_model_kwargs, **kwargs, "return_full_text": False} + parameters = {"return_full_text": False, **_model_kwargs, **kwargs, "return_full_text": False} response = self.client.post( json={"inputs": prompt, "parameters": parameters}, task=self.task From 7feea66862bea18c4633a27ef5dd9464b1e4951a Mon Sep 17 00:00:00 2001 From: Eugene Yurtsev Date: Mon, 12 Feb 2024 22:33:52 -0500 Subject: [PATCH 5/8] Update libs/community/langchain_community/llms/huggingface_hub.py --- libs/community/langchain_community/llms/huggingface_hub.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libs/community/langchain_community/llms/huggingface_hub.py b/libs/community/langchain_community/llms/huggingface_hub.py index 3084b75d42f4c..ff5447dff5459 100644 --- a/libs/community/langchain_community/llms/huggingface_hub.py +++ b/libs/community/langchain_community/llms/huggingface_hub.py @@ -127,7 +127,7 @@ def _call( response = hf("Tell me a joke.") """ _model_kwargs = self.model_kwargs or {} - parameters = {"return_full_text": False, **_model_kwargs, **kwargs, "return_full_text": False} + parameters = {"return_full_text": False, **_model_kwargs, **kwargs} response = self.client.post( json={"inputs": prompt, "parameters": parameters}, task=self.task From e24a6070a24d2ef461e2fab11e97c106aaf0c0ed Mon Sep 17 00:00:00 2001 From: calvinweb <38599774+calvinweb@users.noreply.github.com> Date: Tue, 13 Feb 2024 14:53:24 +0800 Subject: [PATCH 6/8] Make it only for 'text-generation' --- libs/community/langchain_community/llms/huggingface_hub.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libs/community/langchain_community/llms/huggingface_hub.py b/libs/community/langchain_community/llms/huggingface_hub.py index ff5447dff5459..911eb614731f6 100644 --- a/libs/community/langchain_community/llms/huggingface_hub.py +++ b/libs/community/langchain_community/llms/huggingface_hub.py @@ -127,7 +127,7 @@ def _call( response = hf("Tell me a joke.") """ _model_kwargs = self.model_kwargs or {} - parameters = {"return_full_text": False, **_model_kwargs, **kwargs} + parameters = {**({"return_full_text":False} if self.task=="text-generation" else {}), **_model_kwargs, **kwargs} response = self.client.post( json={"inputs": prompt, "parameters": parameters}, task=self.task From 26e5f8a0f5d8cbb73a3aa418c0e216ea2c1be026 Mon Sep 17 00:00:00 2001 From: calvinweb <38599774+calvinweb@users.noreply.github.com> Date: Tue, 13 Feb 2024 20:18:08 +0800 Subject: [PATCH 7/8] Fix format --- libs/community/langchain_community/llms/huggingface_hub.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libs/community/langchain_community/llms/huggingface_hub.py b/libs/community/langchain_community/llms/huggingface_hub.py index 911eb614731f6..a0124910c6b45 100644 --- a/libs/community/langchain_community/llms/huggingface_hub.py +++ b/libs/community/langchain_community/llms/huggingface_hub.py @@ -127,7 +127,9 @@ def _call( response = hf("Tell me a joke.") """ _model_kwargs = self.model_kwargs or {} - parameters = {**({"return_full_text":False} if self.task=="text-generation" else {}), **_model_kwargs, **kwargs} + parameters = {**({"return_full_text":False} if self.task=="text-generation" else {}), + **_model_kwargs, + **kwargs} response = self.client.post( json={"inputs": prompt, "parameters": parameters}, task=self.task From d1c8254028792e8ce0510ce2687d20fdd263425e Mon Sep 17 00:00:00 2001 From: calvinweb <38599774+calvinweb@users.noreply.github.com> Date: Thu, 15 Feb 2024 14:05:38 +0800 Subject: [PATCH 8/8] Update huggingface_hub.py --- libs/community/langchain_community/llms/huggingface_hub.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libs/community/langchain_community/llms/huggingface_hub.py b/libs/community/langchain_community/llms/huggingface_hub.py index a0124910c6b45..e565d50d7a179 100644 --- a/libs/community/langchain_community/llms/huggingface_hub.py +++ b/libs/community/langchain_community/llms/huggingface_hub.py @@ -127,7 +127,8 @@ def _call( response = hf("Tell me a joke.") """ _model_kwargs = self.model_kwargs or {} - parameters = {**({"return_full_text":False} if self.task=="text-generation" else {}), + parameters = {**({"return_full_text":False} + if self.task=="text-generation" else {}), **_model_kwargs, **kwargs}