fallback to similarity search (#4960)

If there are no metadata filters (NO_FILTER), instead of explicitly returning [], it should fallback to a similarity search
langchain-ai · Apr 6, 2024 · 82de094 · 82de094
1 parent 5d0bd45
commit 82de094
Showing 1 changed file with 6 additions and 10 deletions.
diff --git a/langchain/src/retrievers/self_query/index.ts b/langchain/src/retrievers/self_query/index.ts
@@ -123,16 +123,12 @@ export class SelfQueryRetriever<T extends VectorStore>
       myQuery = generatedQuery;
     }
 
-    if (!filter) {
-      return [];
-    } else {
-      return this.vectorStore.similaritySearch(
-        myQuery,
-        this.searchParams?.k,
-        filter,
-        runManager?.getChild("vectorstore")
-      );
-    }
+    return this.vectorStore.similaritySearch(
+      myQuery,
+      this.searchParams?.k,
+      filter,
+      runManager?.getChild("vectorstore")
+    );
   }
 
   /**