Skip to content

Commit

Permalink
add back format, dont run ci in some cases
Browse files Browse the repository at this point in the history
  • Loading branch information
bracesproul committed Jul 30, 2024
1 parent e9577a3 commit f8ad71e
Show file tree
Hide file tree
Showing 2 changed files with 39 additions and 16 deletions.
21 changes: 5 additions & 16 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ name: CI

on:
pull_request:
paths_ignore:
- 'docs/**'
- 'examples/**'
- 'dependency_range_tests/**'
- 'environment_tests/**'
workflow_dispatch: # Allows triggering the workflow manually in GitHub UI


Expand Down Expand Up @@ -34,22 +39,6 @@ jobs:
- name: Check linting
run: yarn run lint

format:
name: Check formatting
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Use Node.js 18.x
uses: actions/setup-node@v3
with:
node-version: 18.x
cache: "yarn"
- name: Install dependencies
run: yarn install --immutable --mode=skip-build
- name: Check formatting
run: yarn run format:check


platform-compatibility:
runs-on: ${{ matrix.os }}
strategy:
Expand Down
34 changes: 34 additions & 0 deletions .github/workflows/format.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
# Run formatting on all PRs

name: Format

on:
pull_request:
workflow_dispatch: # Allows triggering the workflow manually in GitHub UI


# If another push to the same PR or branch happens while this workflow is still running,
# cancel the earlier run in favor of the next run.
#
# There's no point in testing an outdated version of the code. GitHub only allows
# a limited number of job runners to be active at the same time, so it's better to cancel
# pointless jobs early so that more useful jobs can run sooner.
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
format:
name: Check formatting
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Use Node.js 18.x
uses: actions/setup-node@v3
with:
node-version: 18.x
cache: "yarn"
- name: Install dependencies
run: yarn install --immutable --mode=skip-build
- name: Check formatting
run: yarn run format:check

0 comments on commit f8ad71e

Please sign in to comment.