Skip to content

Commit

Permalink
Fix check for update
Browse files Browse the repository at this point in the history
  • Loading branch information
hinthornw committed Nov 11, 2024
1 parent 940032d commit 20b17dd
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
3 changes: 1 addition & 2 deletions python/langsmith/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -5646,8 +5646,7 @@ def push_prompt(
# Create or update prompt metadata
if self._prompt_exists(prompt_identifier):
if any(
param is not None
for param in [parent_commit_hash, is_public, description, readme, tags]
param is not None for param in [is_public, description, readme, tags]
):
self.update_prompt(
prompt_identifier,
Expand Down
6 changes: 3 additions & 3 deletions python/tests/unit_tests/test_run_helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -372,9 +372,9 @@ def my_stream_fn(a, b, d, **kwargs):
]
first_patch = next((d for d in call_data if d.get("patch")), None)
attempt += 1

assert first_patch["name"] == "my_stream_fn"
assert first_patch[0]["outputs"] == {"my_output": expected}
if "name" in first_patch:
assert first_patch["name"] == "my_stream_fn"
assert first_patch[0]["outputs"] == {"my_output": expected}


@pytest.mark.parametrize("use_next", [True, False])
Expand Down

0 comments on commit 20b17dd

Please sign in to comment.